# Pull Request

## Description

This PR makes two small, surgical edits to
**`.github/workflows/copilot-setup-steps.yml`** — the workflow that
prebuilds the Copilot Coding Agent environment:

1. **PowerShell module install scope** — change `-Scope CurrentUser` to
`-Scope AllUsers` for the three required modules (`PowerShell-Yaml
0.4.7`, `PSScriptAnalyzer 1.25.0`, `Pester 5.7.1`). Versions and the
optional `HVE_PSGALLERY_SOURCE_URL` repository registration are
unchanged. `AllUsers` writes modules to
`/usr/local/share/powershell/Modules`, which is on the default
`PSModulePath` for any user and any shell on the runner, so subsequent
workflow steps and ad-hoc shells do not need per-user `PSModulePath`
fixups to resolve the modules.
2. **Remove an erroneous verification line** — drop `npx --no vally --
--version` from the tool verification block. The intended command does
not exist; it was a stray typo (likely from `--no-install` followed by a
partial package name) and currently fails silently or noisily depending
on the environment.

This PR is a **sibling** of #1497, branched off `main`. It is
independent of PRs A/B/C/D in the post-#1497 stack and can land in any
order relative to them.

### Scope

This PR ships **only** the workflow edit. The matching local-environment
changes from the original snapshot (`.devcontainer/scripts/on-create.sh`
and `.vscode/settings.json`) are deliberately deferred to a separate PR
(PR F) pending user confirmation of intent. See follow-on **WI-02** in
the planning log.

## Related Issue(s)

Sibling of #1497. No other issue references.

## Type of Change

Select all that apply:

**Code & Documentation:**

* [x] Bug fix (non-breaking change fixing an issue)
* [ ] New feature (non-breaking change adding functionality)
* [ ] Breaking change (fix or feature causing existing functionality to
change)
* [ ] Documentation update

**Infrastructure & Configuration:**

* [x] GitHub Actions workflow
* [ ] Linting configuration (markdown, PowerShell, etc.)
* [ ] Security configuration
* [ ] DevContainer configuration
* [ ] Dependency update

**AI Artifacts:**

* [ ] Reviewed contribution with `prompt-builder` agent and addressed
all feedback
* [ ] Copilot instructions (`.github/instructions/*.instructions.md`)
* [ ] Copilot prompt (`.github/prompts/*.prompt.md`)
* [ ] Copilot agent (`.github/agents/*.agent.md`)
* [ ] Copilot skill (`.github/skills/*/SKILL.md`)

**Other:**

* [ ] Script/automation (`.ps1`, `.sh`, `.py`)
* [ ] Other (please describe):

## Sample Prompts (for AI Artifact Contributions)

<!-- Not applicable: this PR is a CI workflow adjustment. -->

For detailed contribution requirements, see:

* Common Standards:
[docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md)
* Agents:
[docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md)
* Prompts:
[docs/contributing/prompts.md](../docs/contributing/prompts.md)
* Instructions:
[docs/contributing/instructions.md](../docs/contributing/instructions.md)
* Skills: [docs/contributing/skills.md](../docs/contributing/skills.md)

## Testing

Automated validation performed by the agent:

* `npm run lint:yaml` — **PASS** (50 workflow files, including
`copilot-setup-steps.yml`).
* `actionlint .github/workflows/copilot-setup-steps.yml` — **PASS**
(`EXIT=0`).
* `npm run lint:ps` — *skipped* in the sandbox (PSGallery network
restricted); the diff contains no `.ps1` changes, so PSScriptAnalyzer
would have nothing new to flag.

Security analysis findings:

* No secrets, credentials, or customer data in the diff.
* No new external dependencies. Module names and pinned versions are
unchanged; only the install scope changes.
* `-Scope AllUsers` requires root on the runner. The `copilot-setup` job
already runs as root on `ubuntu-latest`, so no privilege escalation is
introduced.
* No surface area is added: the typo line `npx --no vally -- --version`
is removed, not replaced.

Diff-based assessments:

* Three line-level scope rewrites plus one line removal. Net change: `+3
/ -4`, one file, zero new files, zero structural changes to the workflow
graph.

> [!NOTE]
> Manual testing was not performed. The next live run of
`copilot-setup-steps.yml` on a Coding Agent task will exercise the new
install scope end-to-end.

## Checklist

### Required Checks

* [x] Documentation is updated (if applicable) — *(N/A — workflow-only
change.)*
* [x] Files follow existing naming conventions.
* [x] Changes are backwards compatible.
* [x] Tests added for new functionality (if applicable) — *(N/A — no new
behavior surface.)*

### AI Artifact Contributions

* [ ] Used `/prompt-analyze` to review contribution
* [ ] Addressed all feedback from `prompt-builder` review
* [ ] Verified contribution follows common standards and type-specific
requirements

### Required Automated Checks

The following validation commands must pass before merging:

* [ ] Markdown linting: `npm run lint:md`
* [ ] Spell checking: `npm run spell-check`
* [ ] Frontmatter validation: `npm run lint:frontmatter`
* [ ] Skill structure validation: `npm run validate:skills`
* [ ] Link validation: `npm run lint:md-links`
* [ ] PowerShell analysis: `npm run lint:ps`
* [ ] Plugin freshness: `npm run plugin:generate`
* [ ] Docusaurus tests: `npm run docs:test`

## Security Considerations

<!-- ⚠️ WARNING: Do not commit sensitive information such as API keys,
passwords, or personal data -->
* [x] This PR does not contain any sensitive or NDA information
* [x] Any new dependencies have been reviewed for security issues —
*(N/A — no new dependencies.)*
* [x] Security-related scripts follow the principle of least privilege —
*(N/A — workflow already runs as root on the runner; scope change does
not broaden it.)*

## Additional Notes

Companion PRs in the post-#1497 work stream:

* **PR A (#1638)** — Security Planner state schema and fixtures (stacked
on `feat/sssc-planner-rai-parity`).
* **PR C (#1639)** — Planner disclaimer SSOT migration (stacked on
`feat/sssc-planner-rai-parity`).
* **PR D (#1640)** — Planner linter hardening: `applyTo` regression
guard (sibling off `main`).
* **PR B** — Security Planner agent and phase-gate parity (depends on PR
A); will also carry deferred Pester suites and content edits.
* **PR F** *(future, optional)* — Devcontainer and
`.vscode/settings.json` companion changes, pending user confirmation of
intent (WI-02).

## Summary

Brings the `security-planner` agent, its supporting instructions, and
the shared RAI capture-coaching guidance up to the same phase-gate,
state, and question-cadence parity established by the `sssc-planner`
work in PR #1497. Bundles the planner-startup, cadence Rule 5 ordering,
risk-grid grammar, and state-schema test suites that guard those
conventions going forward.

## Stacking

- **Base:** `stack/security-state-schema` (PR #1638, "PR A")
- **Upstream:** PR #1497 (sssc-planner)
- **Siblings:** PR #1639 (PR C — Disclaimer/Attribution Protocol), PR
#1640 (PR D)
- **Do not merge** until the PR #1497 → PR #1638 cascade completes.

## Changes

**Modified (10):**
- `.github/agents/security/security-planner.agent.md`
- `.github/instructions/security/identity.instructions.md`
- `.github/instructions/security/security-model.instructions.md`
- `.github/instructions/security/backlog-handoff.instructions.md`
-
`.github/instructions/rai-planning/rai-capture-coaching.instructions.md`
- `.github/prompts/security/security-capture.prompt.md`
- `.github/prompts/security/security-plan-from-prd.prompt.md`
- `plugins/hve-core-all/README.md` (auto-regen)
- `plugins/project-planning/README.md` (auto-regen)
- `plugins/security/README.md` (auto-regen)

**Added (5 Pester suites):**
- `scripts/tests/linting/Test-PlannerStateSchema.Tests.ps1` — 8 tests
- `scripts/tests/linting/Test-PlannerStateSchemas.Tests.ps1` — 4 tests
- `scripts/tests/linting/Test-CadenceRule5Ordering.Tests.ps1` — 2 tests
- `scripts/tests/linting/Test-PlannerStartupBlocks.Tests.ps1` — 6 tests
- `scripts/tests/linting/Test-RiskGridGrammar.Tests.ps1` — 7 tests

## Validation

| Check | Result |
| --- | --- |
| `npm run plugin:validate` | ✅ 13 collections |
| `npm run lint:md` | ✅ 211 files, 0 errors |
| `npm run lint:frontmatter` | ✅ 541 files, 0 errors |
| `npm run lint:md-links` | ✅ |
| `npm run lint:ps` | ✅ |
| `Test-PlannerStateSchema` | ✅ 8/8 |
| `Test-PlannerStateSchemas` | ✅ 4/4 |
| `Test-CadenceRule5Ordering` | ✅ 2/2 |
| `Test-PlannerStartupBlocks` | ✅ 6/6 |
| `Test-RiskGridGrammar` | ✅ 7/7 |

## Notes for Reviewers

1. **`disclaimerShownAt: null` in identity state schema** — Adds one
line to the inline state schema in `identity.instructions.md` so the
canonical state shape declares the field with a default. Full
Disclaimer/Attribution Protocol prose that consumes the field remains in
PR C (#1639). Three-way overlap with PR #1639 on this file is expected.

2. **`Test-PlannerStateSchemas.Tests.ps1` assertion direction** —
Authored draft used `Should -Not -Contain 'disclaimerShownAt'` against
the `required` arrays. Per plan decision DD-06/ID-02
(`.copilot-tracking/plans/2026-05-22/stacked-prs-from-pr-1497-plan.instructions.md`
line 41), the snapshot demotion of
`disclaimerShownAt`/`signingManifestPath` from `required` was **rejected
for uniformity** across `security-state`, `rai-state`, and `sssc-state`
schemas. Flipped both assertions to `Should -Contain` so the test now
affirms the documented uniformity decision. Schemas themselves are
unchanged.

3. **Auto-regenerated plugin READMEs** —
`plugins/hve-core-all/README.md`, `plugins/project-planning/README.md`,
and `plugins/security/README.md` reflect descriptive SSSC text drift
produced by `npm run plugin:generate`. Benign; produced by tooling.

4. **Sandbox/environment note** — All Pester suites and
pwsh-yaml-dependent lints (`plugin:generate`, `plugin:validate`,
`lint:frontmatter`, `lint:md-links`, `lint:ps`) require unsandboxed
execution because the `PowerShell-Yaml` module is installed under
`~/.local/share/powershell/Modules`.

## Merge Order

This PR is part of a 5-PR stack split from PR #1497. Merge in this
order:

1. **#1638** — `feat(scripts): security-planner state schema` (base)
2. **#1639** — `feat(prompts): RAI disclaimer/attribution protocol`
(independent of B, but lands before B for review continuity)
3. **#1642** (this PR) — `feat(agents): security-planner SSSC parity`
(depends on #1638)

Independent of the above sequence:

- **#1640** — `feat(scripts): risk-grid grammar enforcement` (no shared
files)
- **#1641** — `chore(plugins): regenerated plugin READMEs` (tooling
output only)

After #1638 and #1639 merge, rebase this branch onto `main` before
merging.

---------

Signed-off-by: williamberryiii <wberry@microsoft.com>
Co-authored-by: Bill Berry <wbery@microsoft.com>

# Pull Request

## Description

This PR adds a single Pester regression guard,
**`scripts/tests/linting/Test-InstructionApplyToScope.Tests.ps1`**, that
enforces phase-narrowed `applyTo` globs on every instruction file under
`.github/instructions/security/**` and
`.github/instructions/rai-planning/**`. Any file whose frontmatter
declares `applyTo: '**'` is rejected unless its repo-relative path is on
the in-script allowlist (currently empty, matching the Phase 6
audit-matrix migration map).

The suite is data-driven (`It -ForEach`) so each scanned file produces a
discrete test case (currently 18 cases, all passing). It uses
`powershell-yaml` (already required by
`scripts/linting/Validate-MarkdownFrontmatter.ps1` and other existing
suites — no new repo-level dependency) and explicitly throws on missing
frontmatter so silent skips cannot mask regressions.

This PR is a **sibling** of #1497, branched off `main`. It is
independent of PRs A/C/B in the post-#1497 stack and can land in any
order relative to them.

### Scope reduction

The originating plan listed four Pester suites under "planner linter
hardening." Three are deferred to **PR B** because they assert content
not yet on `main`:

* Rule 5 "discover" keyword in `security/identity.instructions.md` and
`sssc-identity.instructions.md`.
* `## Startup` H2 in six prompts under `.github/prompts/security/` and
`.github/prompts/security/sssc/`.
* "Informational" bucket in `security-model.instructions.md`.

Shipping those tests now would produce a red base. They will land in PR
B alongside the content edits they exercise.

## Related Issue(s)

Sibling of #1497. No other issue references.

## Type of Change

**Code & Documentation:**

* [x] New feature (non-breaking change adding functionality)

**Infrastructure & Configuration:**

* [x] Linting configuration (markdown, PowerShell, etc.)

**Other:**

* [x] Script/automation (`.ps1`, `.sh`, `.py`)

## Testing

Automated validation performed by the agent:

* `npm run test:ps -- -TestPath
scripts/tests/linting/Test-InstructionApplyToScope.Tests.ps1` — **18/18
passed**.
* `npm run lint:ps` — clean for repository code.

Security analysis findings:

* No secrets, credentials, or customer data in the diff.
* No new runtime dependencies. `powershell-yaml` is already required by
existing linting and test suites.
* No changes that broaden privilege boundaries; the test reads files
only.

Diff-based assessments:

* The new file follows the existing
`scripts/tests/linting/Test-*.Tests.ps1` naming and structure.

> [!NOTE]
> Manual testing was not performed.

## Checklist

### Required Checks

* [x] Documentation is updated (if applicable) — *(N/A — passive
regression test.)*
* [x] Files follow existing naming conventions.
* [x] Changes are backwards compatible.
* [x] Tests added for new functionality (if applicable).

### Required Automated Checks

* [x] PowerShell analysis: `npm run lint:ps`

## Security Considerations

* [x] This PR does not contain any sensitive or NDA information
* [x] Any new dependencies have been reviewed for security issues —
*(N/A — no new dependencies.)*
* [x] Security-related scripts follow the principle of least privilege —
*(N/A — read-only test.)*

## Additional Notes

Companion PRs in the post-#1497 work stream:

* **PR A (#1638)** — Security Planner state schema and fixtures.
* **PR C (#1639)** — Planner disclaimer SSOT migration.
* **PR B** — Security Planner agent and phase-gate parity (depends on PR
A); will also carry the three deferred Pester suites and their content
edits.
* **PR E** — Dev environment alignment (sibling off `main`, optional).